Re: [incron patch] remove unneeded inotify #include's

Hello,
this is not true in some old Linux distributions. These distributions
contain inotify-capable kernels but not the appropritate GNU C Library
headers. There are two ways how to allow to compile incron on these
distributions: to include sys/inotify-syscalls.h or to force users to
install newer glibc headers. I think the first way is better. Have you
experienced any problems with the current solution? If so please let me
know. Thanks.
Lukas

> sys/inotify.h is the one and only header needed.
>
>
> Index: inotify-cxx.h
> ===================================================================
> --- inotify-cxx.h (revision 112)
> +++ inotify-cxx.h (working copy)
> @@ -32,14 +32,8 @@
> #include<map>
>
> // Please ensure that the following headers take the right place
> -#include<sys/syscall.h>
> #include<sys/inotify.h>
>
> -// Use this if syscalls not defined
> -#ifndef __NR_inotify_init
> -#include<sys/inotify-syscalls.h>
> -#endif // __NR_inotify_init
> -
> /// Event struct size
> #define INOTIFY_EVENT_SIZE (sizeof(struct inotify_event))
>
> Index: README
> ===================================================================
> --- README (revision 112)
> +++ README (working copy)
> @@ -23,8 +23,7 @@
>
> 2. Requirements
> * Linux kernel 2.6.13 or later (with inotify compiled in)
> -* inotify headers (inotify.h, sometimes inotify-syscalls.h) installed in
> -<INCLUDE_DIR>/sys. The most common place is /usr/include/sys.
> +* a C library providing sys/inotify.h (e.g. glibc>= 2.4)
> * GCC 4.x compiler (probably works also with GCC 3.4, possibly with
> older versions too)
>
>
Received on Tue Jun 05 2012 - 22:14:21 CEST